Skip to content

[release/9.0] Disable ResolveLinkTarget_Succeeds returnFinalTarget=true for UNC paths#124867

Merged
jozkee merged 2 commits intorelease/9.0from
copilot/fix-symbolic-link-tests
Feb 26, 2026
Merged

[release/9.0] Disable ResolveLinkTarget_Succeeds returnFinalTarget=true for UNC paths#124867
jozkee merged 2 commits intorelease/9.0from
copilot/fix-symbolic-link-tests

Conversation

Copy link
Contributor

Copilot AI commented Feb 25, 2026

ResolveLinkTarget_Succeeds fails with IOException: The specified network name is no longer available on Windows versions that have UNC access disabled, because SymbolicLink_ResolveLinkTarget_PathToTarget_Data was yielding UNC paths with returnFinalTarget=true, causing Windows to actually attempt to resolve \\LOCALHOST\share\path.

Test only change for 9.0 (and 8.0), for 10.0 we backported the fix: #124869.

Co-authored-by: jozkee <16040868+jozkee@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing ResolveLinkTarget_Succeeds test for UNC paths Fix ResolveLinkTarget_Succeeds test failure on Windows with UNC paths disabled Feb 25, 2026
@jozkee jozkee marked this pull request as ready for review February 25, 2026 17:56
Copilot AI review requested due to automatic review settings February 25, 2026 17:56
@jozkee jozkee added Servicing-approved Approved for servicing release disabled-test The test is disabled in source code against the issue area-System.IO and removed disabled-test The test is disabled in source code against the issue labels Feb 25, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates symbolic link test data generation to avoid UNC network resolution failures on Windows configurations where UNC access is disabled, stabilizing CI for ResolveLinkTarget_Succeeds.

Changes:

  • Split SymbolicLink_ResolveLinkTarget_PathToTarget_Data generation to cover returnFinalTarget=false/true only for non-UNC paths.
  • Restrict UNC path cases to returnFinalTarget=false to prevent Windows from attempting UNC resolution.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

@jozkee jozkee changed the title Fix ResolveLinkTarget_Succeeds test failure on Windows with UNC paths disabled [release/9.0] Disable ResolveLinkTarget_Succeeds returnFinalTarget=true for UNC paths Feb 25, 2026
@jozkee
Copy link
Member

jozkee commented Feb 26, 2026

/ba-g dotnet/dnceng#6461.

@jozkee jozkee merged commit 4ba092c into release/9.0 Feb 26, 2026
93 of 103 checks passed
@jozkee jozkee deleted the copilot/fix-symbolic-link-tests branch February 26, 2026 16:56
@jozkee
Copy link
Member

jozkee commented Feb 26, 2026

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0 (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.IO Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants